Julia Signell

Results 268 comments of Julia Signell

Thanks @jorloplaz based on the comments it looks like I was planning to change the approach slightly. Let me see if I can get the new idea working.

> @jsignell Did you get a chance to try out the different approach? I'm also happy to take a look next week if it'll help. :) If you want to...

Ok I fixed the conflict, so should be all good now.

Hey @beckernick thanks for commenting here. There are definitely some expected failures on the windows 3.7 build so you can safely ignore those. I think for this new fucntionality it...

Thanks for writing that up. I have been struggling with some groupby issues in https://github.com/dask/dask/pull/8442 as well. I haven't totally wrapped my head around what the right approach is. There...

Sorry for being slow to this. I'm wondering if there would be performance implications if we just change the `pop` to a `get`. ```diff diff --git a/dask/utils.py b/dask/utils.py index 2510e904e..6f305a783...

Well that leads to a recursion error, but I'll keep thinking.

I did: ``` conda create -n datashader -c pyviz/label/dev datashader conda activate datashader pip install -e .[tests] ``` I was getting 12 skips from having a broken version of skimage:...

> So then the API page should point *here* and say that it is strictly reference? That would probably be the cleanest solution. The API should be just reference, and...

> > The docstring already has a version of this. > > Perhaps I should have said: a better version than already exists there :) :smiling_face_with_tear: yes please feel free...