Juan Pablo Tosso

Results 183 comments of Juan Pablo Tosso

Merged https://github.com/corazawaf/coraza/pull/315

Looks good to me in general, but I'm not sure if it's fine to arbitrarily set the dir mode, maybe we should just generate an error? I think modsecurity won't...

Looks good to me. Could you describe a struct of the expected fields? I think we won't have a problem merging it and saving it as `SecAuditLogFormat KEY_VALUE_JSON` or something...

V3 includes a map flattening utility that can be used to easily achieve this, it would be as simple as: `encoding.MapFlatten(auditLog)`

Waiting approval on https://github.com/corazawaf/coraza/pull/294

Thank you for the update @ethan-gallant , that will be an excellent grafana feature. In the meantime, we could split this into a plugin and close the active PR. What...

You are right, they are configured for ZAP compatibility. This must be reviewed once we begin replacing ZAP for v3. In the meantime we can update the documentation.

@ShiMing-Q it looks promising, do you think @fzipi this should work across nodes in a distributed environment? Or is it's ok to handle it per node?

Last review: ``` 👎 36 test(s) failed to run: ["930110-10" "934120-28" "934120-29" "934120-30" "934120-31" "934130-6" "934130-7" "934130-8" "934130-9" "934130-10" "934131-1" "941310-1" "941310-3" "942190-42" "944200-1" "951110-0" "951120-0" "951130-0" "951140-0" "951150-0" "951160-0"...

@anuraaga @jcchavezs do we have regression tests for tinygo to avoid breaking this milestone?