electron-window icon indicating copy to clipboard operation
electron-window copied to clipboard

Published 20 hours ago • verified publisher icon jprichardson

Added support for file urls with a file-protocol

Open kloener opened this issue 8 years ago • 0 comments

Hi,

I ran into an issue where a filepath with a file-protocol was invalid after args.urlWithArgs was called.

Input: args.urlWithArgs('file:///tmp/index.html', {doThat: 'ok'}) Before: file:///Users/kloener/github/electron-window/file:/tmp/index.html#%7B%22doThat%22%3A%22ok%22%7D After: file:///tmp/index.html#%7B%22doThat%22%3A%22ok%22%7D

I simply added a check for "file://" in row 17 of lib/args.js.

regards, Christian

kloener avatar Jul 13 '17 14:07 kloener