psst

psst copied to clipboard

• Use app ID
• Add appstream file

Related to https://github.com/flathub/flathub/pull/4151 and https://github.com/jpochyla/psst/pull/141

@TheEvilSkeleton What else is there to do to finalize the process, just add the mpris privileged?

I think so. Although, per https://github.com/flathub/flathub/pull/4151#issuecomment-1548697783, they say it'd be better not to add any additional permission and have it done properly. To be frank, I know nothing about MPRIS. @A6GibKm can you help us out?

If I am not mistaken

let mut media_controls = MediaControls::new(PlatformConfig {
            dbus_name: APP_ID,
            display_name: "Psst",
            hwnd,
        })?;

is the required change. Note that while this would be ideal, it is not strictly needed and one could add a sandbox hole for org.mpris.MediaPlayer2.Psst (Psst being the current dbus_name).

@TheEvilSkeleton Do you think this change is reasonable?

In my opinion, yes. I'm in favor of reducing permissions as much as possible. That being said, I'm not well versed in Rust, so I can't give my opinion on the code/implementation.

@TheEvilSkeleton Has the been any movement on this since the Flatpak folks have talked?

Unfortunately, no. I don't have much free time anymore.

I will see if I can find some time to poke at this later.

Yeah it would be good to finally release this thing officially.

Most of the changes for this seem to not be flatpak-specific; maybe merging those separately would be good?

@orowith2os @TheEvilSkeleton Any further interest in seeing if we can get this packaged?

I can only help with packaging-related stuff, but nothing I can help with Rust code