feed icon indicating copy to clipboard operation
feed copied to clipboard

Categories : is there a term/name inversion ?

Open AppSecAmael opened this issue 3 years ago • 0 comments

Describe the bug Hello,

we are using your library to generate json and rss feeds about github security advisories. I tried to add the severity of each vulnerability to the feeds in the form of a "category" but get inconsistent results in rss VS json feeds.

Testing with name="severity" and term = "CRITICAL"

 feed.addCategory("CRITICAL");
feed.addCategory("HIGH");
...
 feed.addItem({
...
 category: [
                {
                    term: item.severity,
                    name: "severity"
                }
            ],
....

XML Result shows that the categories are taken in account in the feed with a term representing the level of criticity.

<feed xmlns="http://www.w3.org/2005/Atom">
    ...
    <category term="CRITICAL"/>
    <category term="HIGH"/>
    <category term="MODERATE"/>
    <category term="LOW"/>

And each entry gets a category with both a label and a term, consistent with the categories displayed in the flow.

<category label="severity" term="MODERATE"/>

But in the JSON flow this category is transformed to a "tag" and this one is displaying the "label" instead of the "term" :

"tags": [
                "severity"
            ]

I expected to get the term here, not the label. Am I interpreting this wrongly ?

Versions :

  • NodeJS: v16.16.0
  • npm/yarn: yarn 1.22.19
  • feed: 4.2.2

Additional context

You can see the flows here : https://azu.github.io/github-advisory-database-rss/

AppSecAmael avatar Aug 10 '22 09:08 AppSecAmael