react-images icon indicating copy to clipboard operation
react-images copied to clipboard

Published 20 hours ago • verified publisher icon jossmac

React 17 support

Open cristiancirstea opened this issue 4 years ago • 6 comments

Is it possible to update the peer dependencies to allow using react 17?

https://github.com/jossmac/react-images/blob/859ef021776186052bb9e46b208c28f51666c776/package.json#L80

cristiancirstea avatar Feb 09 '21 20:02 cristiancirstea

@w01f6 You shouldn't be using this package anymore as it's very broken, but, just for you, I'll do it :)

davwheat avatar Feb 09 '21 21:02 davwheat

@w01f6 Published 1.2.0-beta.1. Give it a go and let me know if you have any issues.

davwheat avatar Feb 09 '21 22:02 davwheat

Just tried it get an import error error - ./node_modules/react-images/dist/react-images.es.js Attempted import error: 'react-full-screen' does not contain a default export (imported as 'Fullscreen').

Looks like its just a typo in the module import? Added a PR

amirhar avatar Feb 12 '21 04:02 amirhar

@amirhar Published 1.2.0-beta.3!

davwheat avatar Feb 13 '21 00:02 davwheat

this issue: seems co-related to the current beta path: https://github.com/jossmac/react-images/issues/396

TheOneAndOnlyGarcia avatar Mar 03 '21 13:03 TheOneAndOnlyGarcia

@w01f6 You shouldn't be using this package anymore as it's very broken, but, just for you, I'll do it :)

great !!

qiutian00 avatar Oct 28 '21 15:10 qiutian00