Josh Triplett

Results 576 comments of Josh Triplett

@epage One issue with some of the test cases listed in this issue: the calls to `try_get_matches_from` need to include the program name as the first argument. Fixing that makes...

I think it'd be perfectly reasonable to just make these non-public before 3.0, as long as the top-level app_from_crate macro still exists. I don't think we have to provide a...

I think there's been a huge amount of focus on the optimization possibilities here, as opposed to the correctness argument. The optimization possibilities would justify creating an option, but not...

@Amanieu We discussed this in today's @rust-lang/lang meeting. We felt like all of the arguments have been made at this point, and now we need to weigh the tradeoffs between...

> This already exists: an unwind guard will call the panic handler with a `PanicInfo` that return false for `can_unwind` (#92988). std's panic handler will call the panic hook as...

We discussed this one in the lang team meeting. This does need an RFC; how quickly that progresses will depend on how smoothly and non-bikesheddy the RFC goes. The approach...

I do think it'd be nice to have a broader RFC that explicitly defines when symbols should be exported, across all use-cases.

@tanriol While it doesn't address your immediate issue, in case you haven't already seen it, https://github.com/rust-lang/rfcs/pull/2137 and https://github.com/rust-lang/rust/issues/44930 may help you in the future.

Echoing a comment from the internals thread: once we have the free function `default`, we could write this as `map_or_else(default, ...)`. I think we should weigh that when deciding if...

I'd love to see this added to the standard library. I share the concern that I'd prefer to not have two types with the same name distinguished only by module....