Josh Levy-Kramer

Some more information to provide some background... Features: * "ngram" - for example if n=2 it produces bigrams for example [["One", "Two"], ["Two", "Three"] ...] * "everygram" - all ngrams...

> It's very nice work, I'm just a bit concerned about the complexity of the implementation for future maintenance. Fair point. I will implement a simpler version and then we...

I have changed the approach and it now chains ngram or skipgram iterators together. Overall its much simpler to understand. Only issue is that you loose the ordering of the...

I have added the Python API. Currently it takes a list and output a list. Do we want the Python interface to take a iterator as input and produce an...

> Though in terms of API it's maybe not ideal that if there are not enough tokens e.g. for `KSkipNGrams(min_n=1, max_n=1, max_k=1)` (here 2) it would error. It's a very...

> decide what should be the default stop word list: either take an english stop word list from somewhere (e.g. spacy), or ask users to explicitly provide one. I think...

Interesting paper. Might be worth including a standard stop word list from spacy but add a note in the documentation that refers to the paper.

I could look into implementing a ngram and skipgram iterator? Similar to the util functions in NLTK http://www.nltk.org/_modules/nltk/util.html#ngrams for characters and words (#2).

PR: #82 Please take a look when you get a chance

@dimitry-ishenko the link you provided shows a 404 error for me @JohanMabille it would be great if there was another way to install xeus-cling without conda. I have a virtual...