Joshua Liebow-Feeser
Joshua Liebow-Feeser
@Shnatsel > What are the work items here? Why does `RUSTFLAGS="-Z sanitizer=address" cargo test --target x86_64-unknown-linux-gnu` not suffice? If it's that simple, then that's great. I know nothing about sanitizers...
Update: We should be able to have this run all the time by editing [test.sh](https://github.com/google/mundane/blob/master/test.sh).
ASan has been implemented here: https://github.com/google/mundane/commit/0148297bf1c5bb8ccc8acbc7abcc15cb4b53d6ee. I'm going to leave this open in case somebody wants to figure out how to get MSan working.
Sorry, it's [on Gerrit](https://fuchsia.googlesource.com/mundane/+/f516499751b45969ac5a95091b1f68cf5ec23f04), which is our source of truth. Our infrastructure for syncing changes from Gerrit to GitHub is broken right now.
Oh! Not sure how I missed that, thanks!. I'll update the description accordingly.
OK, @davidben let me know if the updated issue description seems accurate to you.
Ah interesting. I think it's still probably worth not exposing `Clone` since Rust references are just as good here, and Rust's reference-counting facilities (`Rc` and `Arc`) allow more flexibility wrt...
> For completeness, the built-in ref-counting would avoid an extra allocation and layer of indirection. For C++ code, I think we usually encourage folks to use `bssl::UniquePtr` directly and `bssl::UpRef`...
We've decided to deprecate Mundane, so I'm closing this.
At least on Fuchsia, we're migrating everything to RustCrypto. It's far better staffed, and even if it weren't, we don't have the cycles to maintain Mundane. If someone wants to...