Joshua Liebow-Feeser
Joshua Liebow-Feeser
It's all yours then! I'll warn you that you might want to leave the elfmalloc crate to the end because we're in the middle of a large refactor now, so...
Hmm, unfortunately I'm not sure. I've never actually tried to do this myself (in this project or any other one), so I don't know any more about it than you...
Awesome, thanks for that PR! My only comments were with the commit messages; the code itself seemed to work perfectly. And don't feel rushed in this 😀 Lord knows I've...
@JaromirCharles Sorry I went AWOL for a bit, but it looks like you figured it out, so I merged the PR 😃 . Thanks!
Thanks for the PR, and welcome! Looks good except for one thing: can you squash into a single commit and make the commit message something like `Travis: Add minimum support...
So the Travis builds are failing for reasons that they weren't failing before. Can you take a look at those and make appropriate fixes?
Still getting the same error on some builds, e.g. https://travis-ci.org/ezrosent/allocators-rs/jobs/275984270
Hmm OK, I'll take a look. Might have to do with a bug we just uncovered elsewhere, so we might have to fix that first and then rebase those changes...
Hmm I'm not sure what's going on. For example, on [Linux/Rust nightly](https://travis-ci.org/ezrosent/allocators-rs/jobs/275984268), elfmalloc's tests are resulting in a SIGKILL getting sent to the test process. I'm not sure what that's...
Every one of the builds is now failing with the error `no $ARCH specified`. Are you sure you're clicking on the new builds and not just re-loading an old build...