Joshua Liebow-Feeser
Joshua Liebow-Feeser
That'd be awesome; it's all yours! I've assigned it to you. Github Actions artifacts sounds reasonable for reporting the metrics.
> Maybe I spoke too soon recommending Tarpaulin. Nevertheless, here is an example build using Tarpaulin https://github.com/tommy-gilligan/zerocopy/actions/runs/7986802695 . Where is the coverage information reported there? I don't see it. @jswrenn...
Relevant: https://github.com/rust-lang/rust/issues/28794
IIUC, guaranteeing evaluation order should be enough to mitigate the "unknown attribute" problem: We just ensure that we're placed in a location that evaluates after any attribute macros. That still...
> Question: This branch is already out-of-date and needs changes, do you prefer that I do a merge or that I do a rebase? Rebase please, thanks!
Maybe we could also enable `clippy::unwrap_used` in this PR and get more coverage? Also, we'll probably want some way of disabling these in testing code, since we do want to...
> Updated statistics for `clippy::expect_used`: > > We have one function that is documented as panicing as part of its public API (`FromZeros::new_box_slice_zeroed`). > > We have one function that...
Replying to @davidtgoldblatt's [comment](https://github.com/jemalloc/jemalloc/issues/937#issuecomment-328613080): > @joshlf, the tsd struct is defined at https://github.com/jemalloc/jemalloc/blob/a315688be0f38188f16fe89ee1657c7f596f8cbb/src/tsd.c#L15, with the tls model set in the configure script https://github.com/jemalloc/jemalloc/blob/82d1a3fb318fb086cd4207ca03dbdd5b0e3bbb26/configure.ac#L725. > > Basically, you just need to...