hyperapp-router icon indicating copy to clipboard operation
hyperapp-router copied to clipboard

Allow multiple routers interaction

Open kidandcat opened this issue 7 years ago • 2 comments

Allow multiple routers to coexist by not wrapping the pushstate and replacestate functions multiple times and triggering the router listeners after creating it.

kidandcat avatar May 02 '18 10:05 kidandcat

I still need this change, and I need to rewrite it in node_modules everytime I deploy, so I'm going to fork and publish it to npm

kidandcat avatar May 13 '18 18:05 kidandcat

Codecov Report

Merging #72 into master will decrease coverage by 1.4%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage     100%   98.59%   -1.41%     
==========================================
  Files           6        6              
  Lines          68       71       +3     
  Branches       11       12       +1     
==========================================
+ Hits           68       70       +2     
- Misses          0        1       +1
Impacted Files Coverage Δ
src/location.js 95.45% <66.66%> (-4.55%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8db6747...d5d5f15. Read the comment docs.

codecov[bot] avatar May 15 '18 10:05 codecov[bot]