hyperapp-router icon indicating copy to clipboard operation
hyperapp-router copied to clipboard

Published 20 hours ago • verified publisher icon jorgebucaran

Proper typing for LinkProps.

Open slacktracer opened this issue 6 years ago • 4 comments

TS compiler complains without it... So I wasn't being able to add a class to my links as I learned in https://github.com/jorgebucaran/hyperapp-router/issues/86.

slacktracer avatar May 30 '19 14:05 slacktracer

maybe something like this is better? https://github.com/DefinitelyTyped/DefinitelyTyped/blob/4685bbd27150e7261dd65705b72cc812f9651b43/types/react-router-dom/index.d.ts#L49-L53

frenzzy avatar May 30 '19 15:05 frenzzy

This is the same as #93

frenzzy avatar May 30 '19 15:05 frenzzy

@frenzzy Yeah, noticed it a few minutes ago...

slacktracer avatar May 30 '19 15:05 slacktracer

@frenzzy Actually it's even better as it accounts for all props. Just found out looking the code that all props are passed down...

slacktracer avatar May 30 '19 16:05 slacktracer