realtime

realtime copied to clipboard

This adds a Remotes field in the DESCRIPTION which allows the user to install the package, installing Sean Kross's p5 package. I also added a Suggests for Rbitcoin, as this is used in the vignette.

Looking forward to using this, great job! :)

Not sure about p5 as a remote as I've extended the core of that to suit our needs, so it's all copied in.

On 30 Oct. 2017 11:53 am, "Nicholas Tierney" [email protected] wrote:

This adds a Remotes field in the DESCRIPTION which allows the user to install the package, installing Sean Kross's p5 package. I also added a Suggests for Rbitcoin, as this is used in the vignette.

Looking forward to using this, great job! :)

You can view, comment on, or merge this pull request online at:

https://github.com/ropenscilabs/realtime/pull/3 Commit Summary

• add Remotes for p5 and suggests for Rbitcoin

File Changes

• M DESCRIPTION https://github.com/ropenscilabs/realtime/pull/3/files#diff-0 (7)

Patch Links:

• https://github.com/ropenscilabs/realtime/pull/3.patch
• https://github.com/ropenscilabs/realtime/pull/3.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ropenscilabs/realtime/pull/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AJDpId47KMDqbw_bMatwASpmrkRvx2w7ks5sxSUVgaJpZM4QKkNu .

OK sure thing, perhaps the Imports: p5 line should be removed from the DESCRIPTION? I couldn't install the package with devtools::install() without the p5 library.

Yeah, there's a good chance I've accidentally left some namespace prefix in there but it should all be local (not reliant on the p5 package). I recall seeing the same thing but time pressure and all... there's plenty to clean up.

With the p5 package installed also, it should work. Refer to the vignettes for examples on the master branch, and Jeff's excellent implementations are in his branch.

On Mon, Oct 30, 2017 at 3:03 PM, Nicholas Tierney [email protected] wrote:

OK sure thing, perhaps the Imports: p5 line should be removed from the DESCRIPTION? I couldn't install the package with devtools::install() without the p5 library.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ropenscilabs/realtime/pull/3#issuecomment-340341468, or mute the thread https://github.com/notifications/unsubscribe-auth/AJDpIRztiqI5iSa9HyiGJEWyP24SZbSCks5sxVF-gaJpZM4QKkNu .