Jonathan Rocher

Results 18 comments of Jonathan Rocher

@kjmcclaning Sorry for the delay in getting back to you. I agree with Pietro that this content isn't in a form that can be merged as is IMO. There is...

@ayaknak I don't understand what issue you are trying to report. Could you update the title and/or description or close the ticket?

This is ready for a second look. WX support added, implementation redone for Qt, unit test added.

Test failure only happens with `pyqt`, not `pyqt5` and is triggered by the following exception in the listener: ``` Exception occurred in traits notification handler. Please check the log file...

Thanks for the suggestion @kitchoi . Didn't help with the test failure, but good suggestion anyway, so added.

I just tested this out on Python3.6 and it worked seemlessly. @rkern any bandwidth to take a look?

@matthew-brett : @rkern commented offline that he won't be maintaining this repository anymore, and has switched to using https://github.com/BurntSushi/ripgrep . That implementation is amazing (and very fast) but is non-trivial...

Mind a comment or 2 from me? Good fix but superfluous comment, imprecise title and you left superfluous parenthesis in the return. Thanks for attending, how sprints are going well!