xml-rpc-rs icon indicating copy to clipboard operation
xml-rpc-rs copied to clipboard

Don't use reqwest::blocking resolves #60

Open ict-cloud opened this issue 3 years ago • 0 comments

Hi Jonas

This is a working minimal version without any noticeable regressions for the elimination of reqwest::blocking. I have refactored the transport implementation to use reqwest and used tokio Runtime (in order to avoid additional dependencies) to execute the blocking thread. As a return value I chose the Cursor<String> which lefts the trait untouched and can be properly handled. I also updated to the 2021 syntax and upgraded some of the dependencies.

I hope you find all the necessary work done properly (this is my firs PR for a Rust crate). Otherwise let me know if I need to change anything.

Best P

ict-cloud avatar Mar 28 '22 13:03 ict-cloud