takahe

takahe copied to clipboard

ref https://github.com/jointakahe/takahe/commit/ab3648e05d4d532800d9f4a6d1ecfbca28f8e3d8#commitcomment-132861912

With this, it's possible to use the same logging config ini file for both the web and stator processes. Sample logging config included.

Why introduce an ini file in the docker directory but not use it anywhere?

because there is no start script provided? Where should the config file be?

Well, I more mean that it's odd to check a default in but not have it used; you could either make it an example one not in the docker directory, place it next to the code and have it as a relative-path default, or include it in the documentation.

Personally, I mount the config into the running container and then refer to it on the starting command line, because that allows me to tweak the config without rebuilding the image. That probably isn't what everyone wants to do, though..

Yeah, my deployment infra assumes that a redeploy means a new image. It's mostly a matter of personal taste I suspect.

So what changes do you want to see, @andrewgodwin ?

Well, if there's going to be a default config added to the docker image, I think the image should be set up to use that via environment variable or something.