Jeff Ohrstrom

Results 260 comments of Jeff Ohrstrom

IDK if I'm sold on this actually. I'd +1 to remove it altogether, but IDK if having it as a menu item is better than `help`. `help` is straight forward...

> Should the ACL editor have its own view and controller or would you rather it have it in a modal dialog? Within the files app it should be a...

> Currently it's just an HTML partial in app/views/files/_acl_edit_modal.html.erb which will have to be populated purely by JavaScript. I could alternatively make this a view for the PermissionsController which is...

That said - feel free to open a draft pull request and we can talk about it there. I think I like the checkbox route you're taking there, though I...

> Not clear what you mean by populated purely by JavaScript - OK I know what you mean, but it's not clear why you'd want so much javascript. It seems...

> Right so I have put the partial in a separate file, but what I'm asking about is how to populate the form with ACL data for a given file....

> I don't think that it will make sense to run getfacl on every file we display, Yea I'm thinking libfacl is better, just a maintenance nightmare. I'll look into...

Yea I just tried the `acl` gem and it doesn't work for files on NFS storages (at least mine anyhow). I'm a bit surprised your site only has local files...

Thinking about that gem a little bit more, maybe FFI is a route we can take instead of having to learn C.

> In any case, I'm fine to use FFI if you prefer that to the acl gem. Here's a demo of how I could use it to get the ACL...