John Walley

Results 92 comments of John Walley

I've had a look into this and here's my attempt at explaining the current behaviour. With no `minSize` or `maxSize` set then `defaultSizes` or `resize()` will behave as though the...

I haven't forgotten about this issue, but I'm still not sure how to move it forwards 🤔. It's not obvious to me how to reconcile percentages and absolute sizes and...

Hi @benoist. Sorry I missed this! I've created #236 and will address. Thanks for reporting 👍

Hi @charles-stuart-appdetex. Thanks for the detailed information. I've added a `preferredSize` prop to panes which takes a percentage value. Should be straightforward to expand this to `minSize` and `maxSize`. Ultimately,...

Hi @trombipeti. I agree that this should be supported. A good example is the sidebar in vs code. ![Mar-31-2022 11-38-54](https://user-images.githubusercontent.com/981531/161036805-ca613c74-849b-4084-bf5f-28639231bace.gif) I can't give an ETA on this but perhaps in...

I've been thinking about this and I've created a new issue which might be relevant: #228. Basically, we could introduce the concept of a _preferred size_ for a pane. Perhaps...

A proof of concept. The sidebar has a preferred size of 300. ![Apr-08-2022 12-38-25](https://user-images.githubusercontent.com/981531/162428584-1a1218c7-344e-41dc-a178-7f370e1a9f66.gif)

This is due to a clash of CSS variable names with Monaco. We could change our CSS variable names to be more specific (would be a breaking change?) or document...

Hi @MartinXPN. Yes, that's a real bug you've found! It's also a regression as it was working in a previous version. I'll fix it as soon as I get the...

@MartinXPN I've published [v1.4.2](https://www.npmjs.com/package/allotment/v/1.4.2). Let me know either way, if it works for you 👍. The demo at https://allotment-storybook.netlify.app/?path=/story/basic--persist-sizes looks to work and the problem with the code was fairly...