John Stevenson

Results 43 comments of John Stevenson

> True. I've procrastinated reviewing this PR because changing for the sake of it is usually based on personal opinions and leads to time-consuming reviews... Yup, I'm sure I'm guilty...

@fabpot I am prepared to do more work here if required (since things have changed slightly). If it is not worth the effort, then feel free to bin it.

Please supply a log file, as requested when you created this issue, otherwise we cannot help you.

I have held fire until Slim 3 appears in its final form. When it does, I will update Slim-Static accordingly.

> Why would you like to have this feature? Is there any other software, which uses these C-Records? @bubeck It is actually quite useful: 1. Because it is part of...

You either have to provide your own config.iss or pass the required parameters on the command-line. The latter method is how the build workflow runs: https://github.com/johnstevenson/pl2303-legacy/blob/d5e022802b4bdbd051c17d98bc8217487070a935/.github/workflows/build.yml#L23

Many thanks for this comment. The CLI version worked, although somewhat hacky, but the arrival of Windows 11 with the disabling of the Prolific recommended replacement drivers (PL2303 TA/TB) forced...

The installer is trying to connect through a proxy server (the details of which it found in the Windows registry). Is this intentional?

The array returned from `getCommand` is either escaped by PHP (from 7.4) or by `Process::escapeShellCommand`. Which PHP version are you running? Edit: Sorry, missed the `..bin/php82` bit.

Sorry, but we cannot use this PR because you are escaping a value which could be escaped again later. Looking into the PHP source code, on PHP 7.4 and upwards...