John McFarlane comments

Results 144 comments of


                                            John McFarlane

Replace CMAKE_TOOLCHAIN_FILE with CMAKE_PROJECT_INCLUDE_BEFORE

For CMake variables which are environment variables, I tend to pass them in via Conan profiles in the `[env]` section, but I'm not fussy - whatever works! On Mon 17...

Replace CMAKE_TOOLCHAIN_FILE with CMAKE_PROJECT_INCLUDE_BEFORE

@phyBrackets description updated

Try to be more `explicit`

Another good example of where expectation is confounded is: auto n = elastic_integer{elastic_integer{1000}};

Try to be more `explicit`

C++20 helps: http://en.cppreference.com/w/cpp/language/explicit

Try to be more `explicit`

For previous revisions use techniques described in [P0892](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0892r0.html).

Try to be more `explicit`

Hi @danieagle this might not be the most straight-forward issue to fix right away. Library needs upgrading to C++20 before the `explicit(expression)` form can be used. There might be easier...

Try to be more `explicit`

Possibly related is the ambiguity reported by compiler [here](https://godbolt.org/z/Yfzfrq).

Try to be more `explicit`

May result in removal of hicpp-explicit-conversions and google-explicit-constructor deviations.

Cannot always compare scaled_integer to 0

Related: #431.

Overflow issue during multiplication of negative wide_integers

Hi Nils. That looks like a bug. It should be addressed by #892 which is ongoing.