Standard-Notes-Clipper icon indicating copy to clipboard operation
Standard-Notes-Clipper copied to clipboard

Published 20 hours ago • verified publisher icon johnjones4

Inline images

Open dannysummerlin opened this issue 5 years ago • 10 comments

I've added an option to convert img URL references into data URIs, so that if webpages go offline you can still have a copy of the images. There is probably a lot that could be improved on, but I thought this would be a good start.

dannysummerlin avatar Dec 22 '19 18:12 dannysummerlin

This is great! Thank you! I will dig in on a deeper review after the holidays. Would you mind addressing the lint issues shown on: https://travis-ci.org/johnjones4/Standard-Notes-Clipper/builds/628439009?utm_source=github_status&utm_medium=notification

johnjones4 avatar Dec 23 '19 20:12 johnjones4

I'm on it!

dannysummerlin avatar Dec 24 '19 01:12 dannysummerlin

@dannysummerlin looking good! I just made two comments for you. If you can address those, I will be good to merge this!

johnjones4 avatar Jan 02 '20 14:01 johnjones4

Hey @dannysummerlin just pinging you on this. Do you think you can address my comments this week?

johnjones4 avatar Jan 07 '20 23:01 johnjones4

Hey John, I've got a big project this week/month, so I can't swear when I'll have a chance to take a crack at it, sorry!

---- On Tue, 07 Jan 2020 18:23:41 -0500 John E Jones IV [email protected] wrote ----

Hey https://github.com/dannysummerlin just pinging you on this. Do you think you can address my comments this week?

— You are receiving this because you were mentioned. Reply to this email directly, https://github.com/johnjones4/Standard-Notes-Clipper/pull/20?email_source=notifications&email_token=AFFRHZDIIANPDI3LAZ4TBZDQ4UFH3A5CNFSM4J6M64A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIKURJI#issuecomment-571820197, or https://github.com/notifications/unsubscribe-auth/AFFRHZHTS7SX4U2T2X2DZLTQ4UFH3ANCNFSM4J6M64AQ.

dannysummerlin avatar Jan 11 '20 17:01 dannysummerlin

Just following up on this!

johnjones4 avatar Feb 25 '20 14:02 johnjones4

Any update with this?

bscott avatar Oct 10 '20 02:10 bscott

Hey y'all, I apologize, for several reasons I've actually switched over to Notion as my note-taker and haven't even fired up Standard Notes in a long time. At this point if any of this code is useful, obviously feel free to use it, but I won't be doing any further work in the Standard Notes world.

dannysummerlin avatar Oct 10 '20 18:10 dannysummerlin

@dannysummerlin Thanks for the update, @johnjones4 Are you still active on the project?

bscott avatar Oct 13 '20 20:10 bscott

@bscott yes still active! Just haven't seen any feature requests or bugs come through lately. I'd love some help with this PR if you are willing to help out.

johnjones4 avatar Oct 13 '20 21:10 johnjones4