VolumetricLinesUnity icon indicating copy to clipboard operation
VolumetricLinesUnity copied to clipboard

Add Single Pass Instanced Rendering support

Open johannesugb opened this issue 5 years ago • 7 comments

Support for Single Pass Instanced Rendering has been requested. Further information: https://docs.unity3d.com/Manual/SinglePassInstancing.html

johannesugb avatar Mar 28 '20 13:03 johannesugb

agree, with VR only left eye is rendering the eye in SPI

ilmatematico avatar Jan 28 '21 21:01 ilmatematico

Only my left eye is rendering as well.

jonathanmorlen avatar Apr 21 '21 08:04 jonathanmorlen

Can you confirm that the problem persists with the latest version? I.e. which includes the changes of commit https://github.com/johannesugb/VolumetricLinesUnity/commit/f6569bcc0847c2cdc2cbba4605c461629bcce7ca

johannesugb avatar Apr 21 '21 08:04 johannesugb

Yes, just checked the _LineStripShader.cginc and it has all the changes from that commit. I am using an HP Reverb. and Unity 2020.2.6f1

jonathanmorlen avatar Apr 21 '21 13:04 jonathanmorlen

Any progress on this issue?

jorgeolothar avatar Aug 30 '21 14:08 jorgeolothar

Yes, there is a potential fix. I've updated all branches some minutes ago with code that has been reported to fix the single pass instanced rendering issue. I have yet to test myself in VR, but maybe if you could checkout the code and report back if it has solved it for you, that would help a lot.

Just ensure that you checkout the code from the appropriate branches, i.e. those targeting with the most up-to-date Unity editor versions, I suppose, which are:

I'll wait a few days for feedback and try to test myself in VR before I'll update the assets in the Asset Store.

johannesugb avatar Sep 05 '21 11:09 johannesugb

Those changes worked. Tested on Unity 2021.1.19, OpenVR (Steam Valve Index , Single Pass Instanced) and Oculus (Rift, Single Pass Instanced)

jorgeolothar avatar Sep 07 '21 18:09 jorgeolothar

Thank you :)

johannesugb avatar Jul 03 '23 08:07 johannesugb