dorgflow icon indicating copy to clipboard operation
dorgflow copied to clipboard

Published 20 hours ago • verified publisher icon joachim-n

close #54: Make sure all commands return a value of the type int

Open dungahk opened this issue 5 years ago • 3 comments

Fix #54

dungahk avatar May 01 '20 19:05 dungahk

closing in favour of #56

dungahk avatar Jun 26 '20 22:06 dungahk

Sorry for the lack of response. This completely fell off my radar.

What's your thinking behind closing this in favour of locking the versions? Returning an int from every command doesn't seem like a big deal, and if older versions of Symfony ignore it, then it's an easy way to make it compatible with the various major versions.

We're going to have to support Symfony 4 at some point (well, unless d.org does pull requests by then and makes this tool obsolete, which it looks like it might), so this fix seems more future-proof.

joachim-n avatar Jun 27 '20 07:06 joachim-n

True that, I think #56 was more "safe" from my side as I do not have the full knowledge of the code. I am not 100% sure all the return values are correct on this PR as I haven't tested them all.

dungahk avatar Jun 27 '20 15:06 dungahk