midilib icon indicating copy to clipboard operation
midilib copied to clipboard

Published 20 hours ago • verified publisher icon jimm

Bpm

Open Fukurokudzu opened this issue 2 years ago • 4 comments

Hey, Jimm! Pls have a look at this PR. Not sure it closes #8, but should make life a bit easier, I guess. Thanks!

Fukurokudzu avatar Feb 24 '23 12:02 Fukurokudzu

ex2.mid is the only midi file I found on the internet with different tempos. Testing was quite limited by using that file alone.

Fukurokudzu avatar Feb 24 '23 13:02 Fukurokudzu

@Fukurokudzu thank you so much for this PR! I've just started a new job, so I apologize in advance because it might take me a bit of time to review this. Thank you for this contribution.

jimm avatar Feb 24 '23 13:02 jimm

@jimm thanks and congrats with new job! I'm new to ruby, so I might use that time for some further editing :]

Fukurokudzu avatar Feb 24 '23 13:02 Fukurokudzu

@Fukurokudzu Thank you so much for this PR! I'm sorry that it has taken me so long to review it --- I just started a new job recently.

Please let me know what you think about my comments and questions.

Thanks a lot for your time to review those!

Fukurokudzu avatar Apr 02 '23 14:04 Fukurokudzu