Jiayu Liu

Results 74 comments of Jiayu Liu

@kennetpostigo, for now, the expected version of `moment` is `"moment": "^2.20.1"` as specified in `package.json`. You are using an old version. Do you think it is possible for you to...

before: - #2527 let's do this because it requires no gen code changes

this somehow erred but i don't think they are triggered by the change

i propose to merge this first - as the errors are Java related, which requires separate fixes. the master branch is now failing due to rust failures. this is really...

maybe: - https://github.com/apache/thrift/pull/2627/files can fix the issue

> @Jimexist Could you have a look at that and the gradle issue as well? > > > TestStandardScheme > testPersistentStructs() FAILED > > org.opentest4j.AssertionFailedError at TestStandardScheme.java:44 i'm not sure...

also i think "Build / lib-java-kotlin (pull_request)" shall be able to catch all Java related errors and it is green in this pull request

> Thanks for doing this! > > Those seem to be new errors related to python: > > * https://app.travis-ci.com/github/apache/thrift/jobs/582437473 > * https://app.travis-ci.com/github/apache/thrift/jobs/582437474 > * https://app.travis-ci.com/github/apache/thrift/jobs/582437475 > * https://app.travis-ci.com/github/apache/thrift/jobs/582437476 @fishy...