jidefx-oss icon indicating copy to clipboard operation
jidefx-oss copied to clipboard

Rename refactoring of ValidationUtils and its methods to follow "Bindings" precedent in JavaFX

Open pfurbacher opened this issue 12 years ago • 2 comments

ValidationUtils, and its methods, install() and uninstall(), don't seem to be suitable names to me. I would prefer that the naming follow the JavaFX naming in this regard -- Bindings, bind, and unbind. The renaming refactoring (this is still a beta release?) would result in the following names:

ValidationBindings [replaces "ValidationUtils"] bind(...) [replaces "install()"] unbind(...) [replaces "uninstall()"]

I'm not familiar with Jide Swing libraries, but if the argument is that "we used the names 'Utils' and 'install/uninstall' in those libraries", it doesn't fly with me. Naming is always a touchy subject, but consider this: JideFX is a new library; it's for JavaFX, not Swing, and it's time for more appropriate naming, one which follows the Binding naming precedent in JavaFX. Because, essentially, that's what you are doing here -- binding and unbinding, not installing and uninstalling.

pfurbacher avatar Sep 24 '13 13:09 pfurbacher

I agree with the name of JideFX should follow the JavaFX naming convention. We were trying to do it in a way. However I am not sure if this one should be renamed to "binding" because it has nothing to do with data binding. The "binding" might introduce confusion. I'll see if I can come up with a better name. Please feel free to suggest.

jidesoft avatar Sep 24 '13 15:09 jidesoft

I agree with @jidesoft. The behavior provided by install/ uninstall is not related to JavaFX bindings per-se. Using any form of bind / unbind would be rather confusing IMHO. Alternative names could be apply/ unapply; register / unregister / deregister.

aalmiray avatar Mar 20 '15 15:03 aalmiray