gwt-gradle-plugin icon indicating copy to clipboard operation
gwt-gradle-plugin copied to clipboard

Applying gwt-base using the plugins closure

Open jaromor opened this issue 5 years ago • 2 comments
trafficstars

I was playing around with the example-library project, and I was unable to make gwt-base work when applying it the new way, i.e. via the plugins closure.

plugins {
  id "org.wisepersist.gwtBase"
  //id "org.wisepersist.gwt.gwtBase"
  //id "org.wisepersist.gwt-base"
  //id "org.wisepersist.gwt.gwt-base"
}

What is the correct way please?

I am no Gradle-guru but from what I saw in the source code I could not find anything suspicious in META-INF/gradle-plugins.

jaromor avatar Jan 20 '20 07:01 jaromor

Looking more into the source code, I think I see why gwt-base is not recognized when added via plugins {}:

gwt-gradle-plugin/build.gradle:

gradlePlugin {
    plugins {
        gwtGradlePlugin {
            ...
        }
        // no gwtBaseGradlePlugin here :(
    }
}

jaromor avatar Jan 20 '20 08:01 jaromor

Good finding. When you test it with your project, would you like to create a PR?

jiakuan avatar Jan 21 '20 00:01 jiakuan

Looking more into the source code, I think I see why gwt-base is not recognized when added via plugins {}:

gwt-gradle-plugin/build.gradle:

gradlePlugin {
    plugins {
        gwtGradlePlugin {
            ...
        }
        // no gwtBaseGradlePlugin here :(
    }
}

If this fixes this, I can open a PR. I don't know how to build Gradle plugins. But I seriously need this

pavi2410 avatar Oct 15 '22 16:10 pavi2410

Thanks for the PR, which has been merged. A new release has been created for this fix:

plugins {
  id "org.docstr.gwt" version "1.1.22"
}

jiakuan avatar Oct 21 '22 01:10 jiakuan

Thanks @jiakuan !

pavi2410 avatar Oct 21 '22 07:10 pavi2410