renderthis

renderthis copied to clipboard

Hi,

I think this may be completely intentional, but I noticed that when there is a speaker note on a slide, the slide gets split into 2 pages when saved to pdf with renderthis::to_pdf().

For example, slide 1 below gets split into pages 2 and 3 in the pdf (after the title slide on page 1), while slide 2 is, as expected, only on page 4.

---
title: "test"
format: revealjs
---

## slide 1

![](https://allisonhorst.github.io/palmerpenguins/reference/figures/README-flipper-bill-1.png)

::: notes
-   secret note
:::

## slide 2

![](https://allisonhorst.github.io/palmerpenguins/reference/figures/README-flipper-bill-1.png)

renderthis::to_pdf("test.html")

I don't think I can insert the html into this PR, but here's the resulting pdf.

If you open the rendered slides in Chrome and use Chrome's print menu to print to PDF, do you get the same thing or something different?

hmm this functionally seems ok, although of course i don't want all the extra white space

I tried your reprex and unfortunately I don't think there's anything specific that renderthis can do to help. Bascially, revealjs has a stylesheet that gets applied when printing the slides and in some cases it causes less than optimal pagination.

to_pdf() basically hands off to pagedown::chrome_print() and I do think we should allow more arguments in to_pdf() to be handed down to the underlying function (c.f. #57). But it's not clear to me which settings we would change to yield better results globally.

I tried your reprex and unfortunately I don't think there's anything specific that renderthis can do to help. Bascially, revealjs has a stylesheet that gets applied when printing the slides and in some cases it causes less than optimal pagination.

to_pdf() basically hands off to pagedown::chrome_print() and I do think we should allow more arguments in to_pdf() to be handed down to the underlying function (c.f. #57). But it's not clear to me which settings we would change to yield better results globally.

that's ok! it's a minor inconvenience tbh. please feel free to close this issue.