Johannes Grumböck comments

Results 89 comments of


                                            Johannes Grumböck

Documentation is wrong on encryption at rest alert configuration

@themantissa Thanks for your support. I just wanted to add that for AWS KMS 365 days of automatic rotation is the default and cannot be changed in some cases (https://docs.aws.amazon.com/kms/latest/developerguide/concepts.html#key-mgmt)....

Documentation is wrong on encryption at rest alert configuration

@martinstibbe Thanks for fixing the docs, but honestly this doesn't help me technically. Silently I was expecting that you'll fix the alert for AWS KMS to fire on 365 days...

Documentation is wrong on encryption at rest alert configuration

@themantissa Thank you for your response and for forwarding my thoughts to the PM!

The commenter fails with the error "invalid character '/' looking for beginning of value"

I do get the same error with @main version

The commenter fails with the error "invalid character '/' looking for beginning of value"

I tried 0.1.10 yesterday on a new PR in our private repo and it was working fine again.

The commenter fails with the error "invalid character '/' looking for beginning of value"

Sure. ``` name: tfsec-pr-commenter on: pull_request: jobs: tfsec: name: tfsec PR commenter runs-on: ubuntu-latest steps: - name: Clone repo uses: actions/checkout@v2 - name: tfsec uses: aquasecurity/[email protected] with: github_token: ${{ secrets.GITHUB_ACCESS_TOKEN...

The commenter fails with the error "invalid character '/' looking for beginning of value"

Good point! I had only successful code and not tested a tfsec hit ... need to do that.

Current sort by stopDate is not working good

I'm using version 0.6.1 now and somehow sorting has changed, but don't see in which way. It's no timesort anymore but also not fully alphabetical. Weird. ![image](https://user-images.githubusercontent.com/5127047/128352130-77181c8d-cfd3-4788-8fd6-0473cbc07a46.png)

Adding job-name in order to evaluate correct job_id/name

Any progress on this?

Allow to add inline ignore for tagging terraform ressource

Hi @tommy31 I'm not a maintainer, but I would like to understand the need of this. What do you mean with `prevent resource deletion`? > To prevent ressource deletion when...