Dwifft icon indicating copy to clipboard operation
Dwifft copied to clipboard

Published 20 hours ago • verified publisher icon jflinter

Fix warnings for Xcode 12, when used from SPM

Open DenTelezhkin opened this issue 5 years ago • 2 comments

SPM in Xcode 12 bumps minimum iOS deployment target to iOS 9, which produces warnings when trying to use Dwifft.

This PR fixes that by deleting minimum supported platforms from Package.swift. Please note, that macOS platform stays, because Dwifft minimum requirement for MacOS is higher than SwiftPM minimum deployment target.

I've also fixed couple new warnings from Swift compiler and enabled building for watchOS.

DenTelezhkin avatar Jul 16 '20 11:07 DenTelezhkin

Hi, I also get the enum warning you fixed and some other warnings for public modifer:

/Pods/Dwifft/Dwifft/Dwifft.swift:312:5: 'public' modifier is redundant for instance method declared in a public extension /Pods/Dwifft/Dwifft/Dwifft.swift:318:5: 'public' modifier is redundant for instance method declared in a public extension /Pods/Dwifft/Dwifft/SectionedValues.swift:75:5: 'public' modifier is redundant for initializer declared in a public extension

Maybe you can add those too?

And do you know what's needed to get the PR merged and deployed in a new version?

Pe-te avatar Dec 22 '20 02:12 Pe-te

It's up to maintainer @jflinter I guess. As for the warnings you are mentioning, they are already fixed on master branch.

DenTelezhkin avatar Dec 22 '20 10:12 DenTelezhkin