ngx-markdown

ngx-markdown copied to clipboard

Marked 11.0.0 was released and it doesn't work with latest ngx-markdown 17.1.1:

I am getting the following runtime error in browser when trying to render some simple markdown:

 <markdown 
ngPreserveWhitespaces
ngNonBindable>
  ```html
     TEST
  ```
 </markdown>

core.mjs:11752 ERROcore.mjs:11752 ERROR Error: renderer 'options' does not exist
    at marked.esm.js:2165:31
    at Array.forEach (<anonymous>)
    at Marked.use (marked.esm.js:2097:14)
    at marked.use (marked.esm.js:2357:20)
    at MarkdownService.parseMarked (ngx-markdown.mjs:293:20)
    at MarkdownService.parse (ngx-markdown.mjs:186:29)
    at ngx-markdown.mjs:533:51
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (asyncToGenerator.js:3:1)
    at _next (asyncToGenerator.js:22:1)R Error: renderer 'options' does not exist
    at marked.esm.js:2165:31
    at Array.forEach (<anonymous>)
    at Marked.use (marked.esm.js:2097:14)
    at marked.use (marked.esm.js:2357:20)
    at MarkdownService.parseMarked (ngx-markdown.mjs:293:20)
    at MarkdownService.parse (ngx-markdown.mjs:186:29)
    at ngx-markdown.mjs:533:51
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (asyncToGenerator.js:3:1)
    at _next (asyncToGenerator.js:22:1)

It works fine with marked v10.0.0, even though I see now 9.0.0 is supported officially with ngx-markdown

Best Regards

Same here.. same issue.

That is because marked 11 is not yet supported as indicated by the peer dependencies

https://github.com/jfcere/ngx-markdown/blob/990942bbe502151743279db4efdada33e0f0c568/lib/package.json#L32-L39

For information, I plan to update eventually, but there is not much changes between v9 and v11 (see marked releases notes here: https://github.com/markedjs/marked/releases).

Any plans to make new release?

For information, I plan to update eventually, but there is not much changes between v9 and v11

yes but when upgrade to v11 ngx-markdown not working

The library has been updated to support marked >= 9.0.0 < 13.0.0. Please update ngx-mardown to v17.2.0.