jetstream icon indicating copy to clipboard operation
jetstream copied to clipboard

The `fullname` field should be decoded when displayed to the user

Open paustint opened this issue 2 years ago • 2 comments

Describe the bug and steps to reproduce

  • The fullname field returned from tooling query results should be decoded
  • Also in deploy metadata table, the results should be decoded
  • Also in view metadata modal where we show the tree of metadata items in the left sidebar

For data tables, we can probably add an additional type to ColumnType (e.x. 'encoded-text') or something.

Then add a simple formatter (this is an example, probably best to make a function that makes sure we have a string before calling this) column.formatter = ({ column, row }) => decodeURIComponent(row[column.key] || '');

image

image

image

paustint avatar May 07 '23 15:05 paustint

Will work on this once https://github.com/jetstreamapp/jetstream/issues/340 is pushed to production since I believe we can use the new utils method decodedHtmlEntity() to help resolve this bug.

joiecosby avatar May 12 '23 18:05 joiecosby

@joiecosby - I think for metadata, we can just use the browsers built-in decodeURIComponent since this is encoded differently from what we saw on the other ticket.

paustint avatar May 12 '23 23:05 paustint