gowiththeflow.js icon indicating copy to clipboard operation
gowiththeflow.js copied to clipboard

Published 20 hours ago • verified publisher icon jeromeetienne

Scoped the library and added cross-browser support w/ Array.prototype.forEach shim.

Open keeguon opened this issue 13 years ago • 2 comments

As stated in issue #8 I added a shim for the forEach method and I also made the code a little bit more verbose but at least it's more readable I think a good idea and I also added a minified version of the library.

keeguon avatar Mar 13 '12 15:03 keeguon

Thanks a lot for your pull request :)

  • The forEach is a bad habit of mine. Thanks for correcting it
  • i think it would be better to fix it with a simple for(;;) tho. instead of changing global scope for that.
  • why not add a minified version. one can add a makefile target for future update tho
  • the "fixing" tabs is.. changing the identation to 2 spaces... let say not my style of coding :)
  • what you explain the purpose of the "scoping"?

jeromeetienne avatar Mar 13 '12 16:03 jeromeetienne

i did some work on the code.

7f10033ef98d41245110f2b1940e0576f00859b7 and c51120ff548858ac0ea2aa96f3e879ac7e1d393a

jeromeetienne avatar Mar 13 '12 17:03 jeromeetienne