slack-plugin icon indicating copy to clipboard operation
slack-plugin copied to clipboard

Feature Request - Display both author and committer

Open mikelax opened this issue 9 years ago • 1 comments

As a user in the slack channel, I want to see both the author and committer name(s) displayed for each line in the "Changes" section for a notification.

In the beginning of April, github added support to squash commits when merging a Pull Request. Here is an example of a recent commit on supertest. In this case I am the committer but MugeSo is the author.

Currently the changes for each commit are displaying the committer name only. For our workflow this is usually the same person and will not always be the author of the commit.

I propose the following changes to the attribute: Notification message includes

  • Refactor the logic for the current option commit list with authors and titles. This appears to currently be displaying the committer name, it should instead use the author name.
  • Add a new option called commit list with authors, committers and titles. This will display the same as the previous entry with the addition of the committer

mikelax avatar May 04 '16 21:05 mikelax

I labeled this a bug because

Notification message includes... current option commit list with authors and titles... appears to currently be displaying the committer name

It's also a feature request because of the desire to list authors and committers.

samrocketman avatar May 05 '16 05:05 samrocketman