dependency-check-plugin icon indicating copy to clipboard operation
dependency-check-plugin copied to clipboard

JENKINS-68342: Compare findings against last build

Open guusdk opened this issue 3 years ago • 2 comments

This commit adds two new tables to the "Dependency-Check Results" page for each build:

  1. all findings that are new in this build.
  2. findings that appear to have been fixed (present in the previous build, but not this build).

The implementation depends on comparing Finding instances from the previous build with those from the current build. To do so, equals() and hashCode() implementations have been added to classes that compose the Finding class, which is the majority of changes introduced in this commit. A unit test has been added to verify this behavior.

Two new endpoints have been added that calculate the deltas at runtime. Each of these endpoints are used by a corresponding new table that is added to the ResultAction Jelly view.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

guusdk avatar Apr 25 '22 11:04 guusdk

Is this going to be merged and released?

thigg avatar Jul 04 '22 09:07 thigg

Is this going to be merged and released?

toomasveromann avatar Aug 22 '22 12:08 toomasveromann

Is this going to be merged and released?

toomasveromann avatar Nov 22 '22 12:11 toomasveromann

I do not think. I have to move javascript library to echarts-api and I do not know if populate jenkins with all of these charts have sense

nfalco79 avatar Nov 22 '22 15:11 nfalco79

won't as explained in the JIRA issue

nfalco79 avatar Mar 18 '23 15:03 nfalco79