jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Synced lyrics doesn't autoscroll

Open Extarys opened this issue 1 year ago • 2 comments

Please describe your bug

When using Jellyfin Web UI (same on desktop), the synched lyrics doesn't auto scroll.

The highlighted line should always be in the centre of the viewport IMO, or at least be visible at the bottom. See spotify (or Finamp)

(Thanks for this oh-so-awesome update, btw! <3)

Reproduction Steps

  1. Play a song with synched lyrics
  2. Click the new mega awesome button to display lyrics
  3. skip mid-way or wait until the highlighted line is below viewpoint

Jellyfin Version

10.9.0

if other:

No response

Environment

Client: Web, Desktop Linux
Browser: Firefox

Jellyfin logs

Not needed

FFmpeg logs

Not needed

Please attach any browser or client logs here

Not needed

Please attach any screenshots here

image

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Extarys avatar May 13 '24 01:05 Extarys

Hi, it seems like your issue report has the following item(s) that need to be addressed:

  • The format of the environment section has been altered from the template.
  • You have not provided the ffmpeg log unaltered from the server. Please provide a valid ffmpeg log.

This is an automated message, currently under testing. Please file an issue here if you encounter any problems.

jellyfin-bot avatar May 13 '24 01:05 jellyfin-bot

This was not included as part of the initial implementation so I’m tagging it as an enhancement.

thornbill avatar May 13 '24 02:05 thornbill

I see this is implemented recently. Is it incorporated in the latest releast i.e. 10.9.7? On my end for songs with synced lyrics they are still displayed in plain text as follows without any scrolling:

[00:01.900]Lyrics by:Robert Thiele/George David Weiss
[00:02.860]Composed by:Robert Thiele/George David Weiss
[00:09.820]I see trees of green red roses too

Reapor-Yurnero avatar Jul 13 '24 19:07 Reapor-Yurnero

New features go in major releases so the upcoming 10.10.0 release in this case.

thornbill avatar Jul 14 '24 04:07 thornbill

@Reapor-Yurnero Strange. I have synced lyrics they simply don't auto-scroll yet, but the current line is highlighted. How weird.

image

v10.9.7 but if I recall it started working in 10.9.3 maybe ?

Extarys avatar Jul 14 '24 17:07 Extarys

Okay then this might be a bug?

Does my above lrc format look the same to yours?

On Sun, Jul 14, 2024, 10:21 Extarys @.***> wrote:

@Reapor-Yurnero https://github.com/Reapor-Yurnero Strange. I have synced lyrics they simply don't auto-scroll yet, but the current line is highlighted. How weird.

image.png (view on web) https://github.com/user-attachments/assets/ccdda898-dac8-44ea-a87f-dfa6cd0c1d96

v10.9.7 but if I recall it started working in 10.9.3 maybe ?

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-web/issues/5487#issuecomment-2227419597, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVJW27WBWE3IBVM5NLZQU3ZMKXSFAVCNFSM6AAAAABHTLA3P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGQYTSNJZG4 . You are receiving this because you were mentioned.Message ID: @.***>

Reapor-Yurnero avatar Jul 14 '24 17:07 Reapor-Yurnero

[01:34.56] Ooh, that smell
[01:38.84] Can't you smell that smell?
[01:42.04] Ooh, that smell
[01:46.94] The smell of death surrounds you

Bug wise, I'm not a Jellyfin expert, so I couldn't tell if an option is missing or something else. Maybe create a discussion so we can talk more about it there ? Include which client you're using and your server version. The community will be able to help you check if a new issue is required ;)

Tag me in your discussion once it's created please :)

Extarys avatar Jul 14 '24 18:07 Extarys