minima icon indicating copy to clipboard operation
minima copied to clipboard

Published 20 hours ago • verified publisher icon jekyll

Too-large header spacing on master branch

Open getaaron opened this issue 5 years ago • 4 comments

Hi all,

I'm using minima on the ScheduleBot Blog and recently switched:

Old New
Gemfile gem "minima", "~> 2.5" gem "jekyll-remote-theme"
_config.yml theme: minima remote_theme: jekyll/minima

so that I could use the new custom-head.html feature.

There's now lots of extra spacing above headers. For example, here are some screenshots (from this post if you need a live example):

Old Appearance

image

New Appearance

image

Question

  • Is this change intentional, or a bug?
  • If it's intentional, what's the preferred approach to override it?

getaaron avatar Sep 02 '20 12:09 getaaron

This change was intentionally made in https://github.com/jekyll/minima/commit/88ef462a3725500e6e5bdb27abb258c8c8b1670f. However, I now feel like agreeing with you that the top margin is a bit too much.

ashmaroli avatar Sep 02 '20 12:09 ashmaroli

@ashmaroli I opened a PR, let me know what you think.

getaaron avatar Sep 02 '20 13:09 getaaron

This is only about personal aesthetics. How to make everyone satisfied?

ngzhio avatar Sep 02 '20 13:09 ngzhio

How to make everyone satisfied?

@ngzhio That's very difficult and almost impossible. But in this case, I think we can meet halfway to satisfy the aesthetic qualms of all three parties..

ashmaroli avatar Sep 02 '20 13:09 ashmaroli