jekyll-admin icon indicating copy to clipboard operation
jekyll-admin copied to clipboard

Published 20 hours ago • verified publisher icon jekyll

Jekyll baseurl not applied / Not works in subfolder (relevant for especially for reverse proxy in subfolder)

Open gsantner opened this issue 7 years ago • 14 comments

Description:

I have set baseurl: /wiki in _config.yml and expected to get admin available on /wiki/admin/, but it doesn't work. Jekyll-Admin doesn't respect the setted baseurl.

Especially when serving through reverse proxy this is bad, because everything in Jekyll does use baseurl, but not jekyll-admin.

Tell us a bit about yourself:

  • Version of JekyllAdmin I'm using 0.8.1
  • Version of Jekyll I'm using 3.83
  • Operating System deb9

Steps to reproduce:

Set baseurl: /something and jekyll-admin listens at wrong location - /admin instead of /something/admin.

I expected the following:

Listening at /something/admin.

gsantner avatar Jul 29 '18 12:07 gsantner

I have the same issue. jekyll-admin disregards baseurl specified like jekyle serve --baseurl /example

kwalski avatar Sep 12 '18 11:09 kwalski

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

jekyllbot avatar Nov 12 '18 12:11 jekyllbot

Still the case, responses from users are there, but none from jekyll devs.

gsantner avatar Nov 27 '18 00:11 gsantner

@gsantner Sorry for the hassle. Unfortunately this repo is not actively maintained. I will take a look at this when I get a chance!

mertkahyaoglu avatar Nov 27 '18 08:11 mertkahyaoglu

@mertkahyaoglu Oh, sorry too. Did look for maintainence notice but there was none at README, should have checked commit history :D. Thanks for any work here, regardless if fixed

gsantner avatar Nov 27 '18 19:11 gsantner

Hello Here is a first attempt to fix this issue Feel free to test and comment, details are in the PR

lexoyo avatar Apr 15 '19 02:04 lexoyo

Is someone still interested in this? @gsantner @kwalski @mertkahyaoglu

lexoyo avatar Apr 23 '19 00:04 lexoyo

I would love this fix

kwalski avatar Apr 23 '19 01:04 kwalski

ok thx, I was not sure anymore :) if you know how to test it that would help, before it is released otherwise, tests will be for after I release it

lexoyo avatar Apr 23 '19 14:04 lexoyo

if you know how to test it that would help, before it is released

Going through existing tests may provide an insight. More info at: https://jekyll.github.io/jekyll-admin/development/

ashmaroli avatar Apr 23 '19 15:04 ashmaroli

All unit tests pass, I was thinking real life tests.

Only the fonts problem remain so I think it would be useful at this stage

lexoyo avatar Apr 23 '19 18:04 lexoyo

@mertkahyaoglu Is there a chance that @lexoyo 's PR at #471 gets merged? It's still impossible to serve as /wiki/ and edit via /wiki/admin/.

gsantner avatar Aug 01 '19 08:08 gsantner

Thx for your support @gsantner Did you test it? Did it work as expected?

Please do not merge yet, there is still a problem with fonts, which I'll address if someone has tested the rest and it works as expected

lexoyo avatar Aug 01 '19 12:08 lexoyo

Hey, I don't use jekyll-admin anymore, and never really have actively. I suggest actual users to try it :)

gsantner avatar May 02 '20 20:05 gsantner