jekyll-admin

jekyll-admin copied to clipboard

Fixes #321

When you provide an array of config files via the --config switch, we'll read and write to the first of such files.

• [x] add code
• [x] test code

What's the desired user experience here?

Primarily, to be in sync with existing Jekyll functionality and be able to edit the site built/served with the specified configuration file.

--

To only be able to modify the first configuration file? Would it make more sense to abstract configuration into configuration files?

When the user builds/serves via a list of config files, its understood and documented that the effective config hash will be a merged singularity. But instead of displaying contents of all the config files in the list, we shall simply allow writing to the first of specified config files.

--

How often do we think users will want to modify secondary configuration files?

Jekyll's build options allow one to specify custom config files. JekyllAdmin's UX gets hampered when we turn a blind-eye to an existing long-standing core functionality.

--

IIRC having a singular configuration file was a purposeful design decision to keep things slim (but that doesn't mean it can't be changed now if there's a strong reason).

For initial release, that was a wise decision. But its time to expand the scope.. :grin:

I believe this is ready a final review..

Update: This will not work on Jekyll-3.5.0. Expecting refinements from Jekyll itself..

@mertkahyaoglu @benbalter Guys, I believe this is once again ready for a scrutiny.. I temporarily disabled a Rubocop check to have it handled as required in a separate PR..