Jeff Sieu comments

Results 4 comments of


                                            Jeff Sieu

Adaptive Icon Foreground needs to have padding otherwise ends up stretching

@taliptako @MarkOSullivan94 According to [Android Developer guidelines](https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive): > The inner 72 x 72 dp of the icon appears within the masked viewport. The system reserves the outer 18 dp on...

Add support for year-long modules to module planner

@ZhangYiJiang How should I proceed with this PR? I really wish to see these changes be incorporated.

Add support for year-long modules to module planner

@ZhangYiJiang Most issues should be resolved. There's currently still a circular dependency between types/planner.ts and types/reducers.ts.... I'm not sure how to resolve this without shifting the type declarations over from...

Disable scroll in upperLayer when state is not AnimationState.expanded

There is a bug in this, where scrolling the `ListView` is still possible, even when the sheet is in a `collapsed` state. This happens when the sheet is programmatically collapsed...