discord-ban-appeal icon indicating copy to clipboard operation
discord-ban-appeal copied to clipboard

Deny & Block gives error

Open docimin opened this issue 3 years ago • 26 comments

Did you follow the steps outline in the README?

  • [x] Yes I did
  • [ ] No, I found them confusing

Describe the bug Wanting to deny & block gives an error, pretty self-explanatory.

To Reproduce Steps to reproduce the behavior:

  1. send appeal
  2. press deny & block
  3. get error

Expected behavior Blocks user

Screenshots image

Desktop (please complete the following information):

  • Browser, all versions and such, is backend error.

docimin avatar Mar 30 '22 21:03 docimin

Can you share your repo's url with me?

jcsumlin avatar Mar 31 '22 14:03 jcsumlin

I have invited you to the repo. https://github.com/docimin/discord-ban-appeal

docimin avatar Apr 06 '22 07:04 docimin

Hello.

I'm experiencing the same issue as @docimin.

MrFoxyOfficial avatar Jun 21 '22 09:06 MrFoxyOfficial

Same issue as well. Hmm

EternalllZM avatar Jul 04 '22 22:07 EternalllZM

@jcsumlin Any update on this? It's been 4 months.

net-tech avatar Jul 04 '22 23:07 net-tech

Hey all sorry for the delay here could you all please check your netlify deploy logs under the build section? There should be some messages that look like this: image

But of course your repo url should show there instead of mine. If this is not the case then that is the issue. You can fix this by running a redeployment in netlify or editing the src/config.json file yourself and adding your GitHub url in there.

jcsumlin avatar Jul 05 '22 14:07 jcsumlin

image

MrFoxyOfficial avatar Jul 05 '22 15:07 MrFoxyOfficial

@MrFoxyOfficial After this are you still having issues with the deny and block button?

jcsumlin avatar Jul 05 '22 15:07 jcsumlin

@jcsumlin correct, still experiencing the same issue.

EDIT: Forgot to add it to the image.

MrFoxyOfficial avatar Jul 05 '22 15:07 MrFoxyOfficial

@jcsumlin correct, still experiencing the same issue.

EDIT: Forgot to add it to the image.

Can you please check to see if your repository is behind mine at all? I just ran through the flow and got a "success" at the end. If there are no differences between your fork and my repo please try and edit the src/config.json file and paste this in there

{"blocked_users":["508313640554987540"],"repository_url":"https://github.com/MrFoxyOfficial/lycanbanappeals"}

jcsumlin avatar Jul 05 '22 16:07 jcsumlin

Other than your #28, not really.

MrFoxyOfficial avatar Jul 05 '22 16:07 MrFoxyOfficial

Done as you've asked: image image

I've added the line as you've requested, but still the same error.

MrFoxyOfficial avatar Jul 05 '22 16:07 MrFoxyOfficial

This is a new error, Im investigating a little further

jcsumlin avatar Jul 05 '22 16:07 jcsumlin

@MrFoxyOfficial do you have a few minutes to jump on a discord call so I ask a few questions about your environment?

jcsumlin avatar Jul 05 '22 16:07 jcsumlin

@jcsumlin sure thing: MrFoxy.eth#6401

MrFoxyOfficial avatar Jul 05 '22 16:07 MrFoxyOfficial

Hello,

I attempted to follow every instruction posted here regarding the deny and block fixes and end up with the same error. For what you asked to put in config, I also did that with my repository as shown in the pictures

screenshot2 screenshot1 .

EternalllZM avatar Jul 05 '22 17:07 EternalllZM

I see you're using the SSH Github url, please use the https url

jcsumlin avatar Jul 05 '22 17:07 jcsumlin

I don't think I understand, sorry. I replaced the URL in the config suggestion with my repo seen here.

EternalllZM avatar Jul 05 '22 17:07 EternalllZM

That is the correct URL now

jcsumlin avatar Jul 05 '22 17:07 jcsumlin

That is what I originally had in the file when I replaced it, you can view the history of the file to see it was all replaced as seen now.

EternalllZM avatar Jul 05 '22 17:07 EternalllZM

And after placing the https url in that file you are still seeing the git:github.com:.... url come up in the deploy logs?

jcsumlin avatar Jul 05 '22 18:07 jcsumlin

It is still showing yes. I even redid the config again just now to see.

EternalllZM avatar Jul 05 '22 18:07 EternalllZM

Ok that is a new case that I was not aware i needed to cover, I will open a new issue and tag you in it. it is somewhat related to this ticket but deserves it own for documentation sake.

jcsumlin avatar Jul 05 '22 18:07 jcsumlin

Okay, I see the new issue you tagged me in. If you need me to test or do anything just let me know.

Is it an error if the embed doesn't update after accepting or denying to show someone has taken action? Does it also have a check for whether an appeal has already been accepted when accepting? Do accepted appeals deny the user from making another one? Just making sure that these are not also errors and intended functionality.

EternalllZM avatar Jul 06 '22 17:07 EternalllZM

Is it an error if the embed doesn't update after accepting or denying to show someone has taken action?

Since these actions are being preformed by the site and not the bot this is the expected behavior.

Does it also have a check for whether an appeal has already been accepted when accepting?

It will display a message saying that user is no longer banned.

Do accepted appeals deny the user from making another one?

If you have the REACT_APP_SKIP_BAN_CHECK set to false only users who are currently banned may submit an appeal. Setting this to true will allow any user to submit an appeal even if theyre not banned.

jcsumlin avatar Jul 06 '22 17:07 jcsumlin

I'm not sure what happened. All I did recently was change my site's domain and somewhere in that whole mess the Deny and Block feature now works out of the blue. I wish I could provide more information, but it just happened out of nowhere and what I did is too unrelated to say something fixed it.

EternalllZM avatar Jul 12 '22 03:07 EternalllZM

@jcsumlin is the GITHUB_PAT field added to prevent this issue or are you still working on this? Saw a draft PR, but not sure the status since I'm getting the same errors listed here.

bxpana avatar Nov 15 '22 01:11 bxpana

@jcsumlin is the GITHUB_PAT field added to prevent this issue or are you still working on this? Saw a draft PR, but not sure the status since I'm getting the same errors listed here.

The PAT is required for the deny and block feature to work in the first place. If you're not supplying it it will always raise an error.

jcsumlin avatar Nov 15 '22 23:11 jcsumlin

@jcsumlin Got it, thank you! Got it working

bxpana avatar Dec 02 '22 21:12 bxpana