John Baublitz

Results 225 comments of John Baublitz
trafficstars

@jethrogb @emilio I now have two projects that I'm a part of that depend on this so I'd willing to help. Where do you want me to start? Does the...

@mulkieran I believe [this is expected](https://github.com/stratis-storage/stratisd/blob/master/src/engine/strat_engine/backstore/crypt/shared.rs#L837-L851). For wiping crypt devices on destroy, we have a wipe block of a sector and the metadata for LUKS2 is approximately 16MiB. Would you...

Blocked by stratis-storage/project#51 or more specifically the PR #1614.

> Therefore the expect won't really go away in the dbus call, it's just moved somewhere else right? I have looked into this a bit and I think I agree...

Maybe there is a way to do it with `Entry` after all! I looked into this API and it looks very promising. I'm happy to remain the owner of this...

@mulkieran Transferring to you. I think I was a little overeager about this potentially working. I've done some digging and the `Entry` API gives different errors from the previous approach...

I think this is potentially obsolete now that we've introduced multi-threading.

My guess is that we can search the code base for something like `io::ErrorKind::Other` to see if we are returning this anywhere. If we aren't, we'll have to do some...

@drckeefe I think I found where we're running into issues. It should be one of three places: [here](https://github.com/stratis-storage/stratisd/blob/develop/src/engine/strat_engine/thinpool/mdv.rs#L57), [here](https://github.com/stratis-storage/stratisd/blob/develop/src/engine/strat_engine/thinpool/mdv.rs#L114), or [here](https://github.com/stratis-storage/stratisd/blob/develop/src/engine/strat_engine/thinpool/mdv.rs#L175). My guess would be that it's [the `create_dir()` call](https://github.com/stratis-storage/stratisd/blob/develop/src/engine/strat_engine/thinpool/mdv.rs#L55)...

Hi @cgwalters, thanks for the feedback! > Could use my openat-ext crate to write files more atomically https://github.com/coreos/bootupd/blob/6e1c089ccfea1aa6b1651c5eced7bba4c4048811/src/backend/statefile.rs#L95 (uses O_TMPFILE, also makes it convenient to serialize directly to file instead...