jbang icon indicating copy to clipboard operation
jbang copied to clipboard

fix: concurrent modification of repos

Open maxandersen opened this issue 3 years ago • 2 comments

this makes https://github.com/jbangdev/jbang/issues/1409 go away but i'm not happy that it is necessary.

it indicates double resolving is occurring as mavenrepo gets added when it should not.

@quintesse suggestions or you think this is valid?

maxandersen avatar Jul 18 '22 20:07 maxandersen

Codecov Report

Merging #1410 (172f754) into main (a230f53) will decrease coverage by 0.04%. The diff coverage is 14.28%.

@@             Coverage Diff              @@
##               main    #1410      +/-   ##
============================================
- Coverage     56.98%   56.93%   -0.05%     
- Complexity     1204     1205       +1     
============================================
  Files           104      104              
  Lines          6288     6295       +7     
  Branches       1032     1034       +2     
============================================
+ Hits           3583     3584       +1     
- Misses         2223     2229       +6     
  Partials        482      482              
Flag Coverage Δ
Linux 55.77% <14.28%> (-0.05%) :arrow_down:
Windows 56.36% <14.28%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/main/java/dev/jbang/dependencies/MavenRepo.java 75.00% <14.28%> (-25.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a230f53...172f754. Read the comment docs.

codecov[bot] avatar Jul 18 '22 20:07 codecov[bot]

I'd have to look into this more closely tomorrow. But the first thing we'd have to check is if this still happens with the refactor of the Project PR.

quintesse avatar Jul 18 '22 22:07 quintesse

was fixed by other means.

maxandersen avatar Sep 01 '22 05:09 maxandersen