jbang icon indicating copy to clipboard operation
jbang copied to clipboard

feat: introduced `build.jbang`

Open quintesse opened this issue 3 years ago • 4 comments

Is basically a file that only supports //-lines, no source. You add the source by using a //SOURCES line.

quintesse avatar Jun 22 '22 14:06 quintesse

It's just a very basic implementation right now. There's no validation yet, so you could for example create a build.jbang file without a //SOURCES line and that would probably fail horribly.

quintesse avatar Jun 22 '22 14:06 quintesse

Codecov Report

Merging #1384 (8b4ef83) into main (9faf9f8) will decrease coverage by 57.29%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main   #1384       +/-   ##
============================================
- Coverage     57.29%   0.00%   -57.30%     
============================================
  Files           104     105        +1     
  Lines          6323    6370       +47     
  Branches       1036    1042        +6     
============================================
- Hits           3623       0     -3623     
- Misses         2215    6370     +4155     
+ Partials        485       0      -485     
Flag Coverage Δ
Linux 0.00% <0.00%> (-56.12%) :arrow_down:
Windows 0.00% <0.00%> (-56.70%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/dev/jbang/cli/Alias.java 0.00% <0.00%> (-50.43%) :arrow_down:
src/main/java/dev/jbang/cli/App.java 0.00% <0.00%> (-52.55%) :arrow_down:
src/main/java/dev/jbang/cli/Build.java 0.00% <0.00%> (-100.00%) :arrow_down:
src/main/java/dev/jbang/cli/Edit.java 0.00% <0.00%> (-44.13%) :arrow_down:
src/main/java/dev/jbang/cli/Export.java 0.00% <0.00%> (-64.34%) :arrow_down:
src/main/java/dev/jbang/cli/Info.java 0.00% <0.00%> (-60.47%) :arrow_down:
src/main/java/dev/jbang/cli/JBang.java 0.00% <0.00%> (-61.49%) :arrow_down:
src/main/java/dev/jbang/cli/Run.java 0.00% <0.00%> (-66.67%) :arrow_down:
src/main/java/dev/jbang/source/Code.java 0.00% <ø> (-71.43%) :arrow_down:
src/main/java/dev/jbang/source/Jar.java 0.00% <0.00%> (-72.55%) :arrow_down:
... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jun 22 '22 14:06 codecov[bot]

should we make this feature enabled only when --preview specified as we discussed?

especially since the format of build.jbang most likely isn't going to stay at being // based.

maxandersen avatar Jul 14 '22 07:07 maxandersen

should we make this feature enabled only when --preview specified as we discussed?

Sure, that's okay with me.

quintesse avatar Jul 14 '22 07:07 quintesse

Ok, will merge this as-is and any improvements/refactorings will be made in future PRs.

quintesse avatar Aug 12 '22 10:08 quintesse