Josh Baldwin

Results 38 comments of Josh Baldwin

Hey no prob, I appreciate you jumping in, take your time. Congratulations 🎉

I think we just need to recheck if there is anything in `await_suspend()` since there is the two function calls? Unconditionally sleeping I think is the problem since something can...

@ryanolson I've got a PR up that I think fixes this, working on adding a test to reproduce on the old code as well.

I don't think my test case is reproducing because the consumer task jumps pools, I'll need to explicitly use std::thread probably to reproduce.

@ryanolson I've managed to reproduce the test on the `main` branch, and it appears to be passing now, please take a look if you have sometime, thanks.

Yeah, I was unable to think of a good suggestion for a generic prefix as `base64_` logically makes sense for this library. How about an optional configuration define or macro...

Would this require a `LIBCORO_FEATURE_THREADING_WINDOWS|LINUX` cmake option if I'm understanding correctly? What about detecting the compiler/platform and including the appropriate features that way and keeping the option named the same?...

I think this makes a lot of sense now that you broken it down, I like it a lot. I will note thought that the original ask behind `LIBCORO_FEATURE_THREADING` was...

I'm not that familiar with io_uring yet, it seems quite promising but this is definitely a larger task to either: (a) replace epoll with io_uring -- this solution would mandate...