django-user-sessions icon indicating copy to clipboard operation
django-user-sessions copied to clipboard

Possibility of a new Release

Open davidhalter opened this issue 4 years ago • 3 comments

Thanks a lot for django-user-sessions. It has been working great for us.

I wanted to ask if it was possible to create a new release? It has been a while and a few patches have landed.

The main reason why I would prefer a new release is https://github.com/jazzband/django-user-sessions/pull/114, which made samesite cookie configuration possible. The current release defaults to None, which is not the Django default. This is probably my main gripe with it: You would expect the Django default, which is not the case.

Again thanks for caring about this project for such a long time!

davidhalter avatar Jun 17 '21 16:06 davidhalter

Please refer to #123 to help improve this situation!

Bouke avatar Apr 16 '22 06:04 Bouke

I'd like to tag a new 2.0 release if there are no objections.

Jumping to 2.0 since there's breaking changes (mostly, dropping older Python version).

Any comments?

WhyNotHugo avatar Oct 10 '22 17:10 WhyNotHugo

I think this is fine. If you have the time, it would be nice if the breaking changes were documented. But I would be fine with a new release in whatever version :).

davidhalter avatar Oct 11 '22 07:10 davidhalter

+1

viktorix avatar Oct 20 '22 15:10 viktorix

A release would be nice to avoid such "hacks": https://github.com/jazzband/django-two-factor-auth/pull/566

Is there anything preventing the release?

claudep avatar Oct 26 '22 15:10 claudep

Will tag a release after merging https://github.com/jazzband/django-user-sessions/pull/147

WhyNotHugo avatar Nov 04 '22 11:11 WhyNotHugo

Is there anything preventing the release?

master doesn't work with Python 3.6. That Python is EOL, so we should drop it too.

WhyNotHugo avatar Nov 04 '22 11:11 WhyNotHugo

Currently needing approval: https://github.com/jazzband/django-user-sessions/pull/149 and https://github.com/jazzband/django-user-sessions/pull/147

WhyNotHugo avatar Nov 12 '22 23:11 WhyNotHugo

My review doesn't count. Would I need to become a member of jazzband for it to count?

davidhalter avatar Nov 13 '22 08:11 davidhalter

@davidhalter Yes. You're welcome to join. See https://jazzband.co/

WhyNotHugo avatar Nov 13 '22 11:11 WhyNotHugo

Release tagged: https://github.com/jazzband/django-user-sessions/releases/tag/2.0.0

There's a wheel and source tarball ready.

I'll wait until the end of the day before pushing this to PyPI. If anyone wants to early test the above artefacts, feedback is welcome.

WhyNotHugo avatar Nov 15 '22 11:11 WhyNotHugo

Oh, I'm only a member so can't release new versions, @ricco386 can you chime in?

Via https://jazzband.co/projects/django-user-sessions

WhyNotHugo avatar Nov 15 '22 17:11 WhyNotHugo

@jezdez, maybe you can add @WhyNotHugo as project lead here?

claudep avatar Nov 19 '22 10:11 claudep

https://pypi.org/project/django-user-sessions/2.0.0/

WhyNotHugo avatar Dec 13 '22 14:12 WhyNotHugo

:rocket:

claudep avatar Dec 13 '22 14:12 claudep