django-payments icon indicating copy to clipboard operation
django-payments copied to clipboard

`process_data` and `static_callback` do not handle PaymentError

Open m-sanders opened this issue 9 years ago • 6 comments

payments.urls.process_data and payments.urls.static_callback do not handle PaymentError and there appears to be no documented preferred method to catch these. For example when using Saleor with PayPal INSTRUMENT_DECLINED results in a 500.

Am I supposed to implement and replace these views?

m-sanders avatar Nov 04 '16 14:11 m-sanders

You are correct, this is something we've discovered about PayPal only recently. We need to handle this in the library.

patrys avatar Nov 04 '16 15:11 patrys

There was this: https://github.com/mirumee/django-payments/pull/78 which seemed to catch it but it does not appear to have made it to master.

m-sanders avatar Nov 04 '16 15:11 m-sanders

@patrys Do you have any recommendations as a temporary workaround for this issue or ideas on how you would like it fixed so I can submit a PR? Thanks.

m-sanders avatar Nov 04 '16 16:11 m-sanders

I believe @mociepka has a working fix/workaround for this. Michał?

patrys avatar Nov 20 '16 19:11 patrys

I ran into this problem today. Any news?

vhf avatar Nov 05 '18 19:11 vhf

I'm suspecting this issue occurs when a payment is declined on paypal.com and the customer clicks the link to return to the originating site. Hoping to verify with an affected customer today. In any case, the above merge request #203 should solve this, though I'll post again after I know for sure.

BenSturmfels avatar Dec 12 '18 03:12 BenSturmfels