django-fsm-log icon indicating copy to clipboard operation
django-fsm-log copied to clipboard

Attempt to fix tests

Open ticosax opened this issue 3 years ago • 1 comments

ticosax avatar Aug 31 '22 09:08 ticosax

Codecov Report

Merging #144 (bbdf741) into master (408828d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files          25       25           
  Lines         506      506           
=======================================
  Hits          481      481           
  Misses         25       25           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 31 '22 09:08 codecov[bot]

Hi @MRigal any new on this?

lorenzomorandini avatar Oct 05 '22 10:10 lorenzomorandini

@lorenzomorandini you can also provide a review I believe.

ticosax avatar Oct 05 '22 13:10 ticosax

I still can't merge it. I don't know how to unblock this PR. image

ticosax avatar Oct 11 '22 06:10 ticosax

Just a little above it says that a review is required from someone that has write access. Since you have it, are you sure you can not do it on your own?

immagine

lorenzomorandini avatar Oct 12 '22 10:10 lorenzomorandini

I can not approve my own PR. It's a bottleneck in the current permission system as it is currently configured for django-fsm-log. I will ask jazzband roadies what they recommend.

ticosax avatar Oct 13 '22 08:10 ticosax

Thanks @hugovk

ticosax avatar Oct 18 '22 15:10 ticosax