django-debug-toolbar
django-debug-toolbar copied to clipboard
handling the case if return_value is None in get_many
Hi,
I ran into a case where I am trying get_many with empty list, in that case, debug toolbar is throwing exception and the toolbar is not appearing. Here I came up with a fix. I think that if return_value is None it's neither a cache miss nor a cache hit right??? Please review and merge if the code is correct.
Hey @robhudson and @aaugustin,
can you both review the above PR ???
Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@e78ac8c). Click here to learn what that means. The diff coverage is0%.
@@ Coverage Diff @@
## master #1029 +/- ##
=========================================
Coverage ? 84.15%
=========================================
Files ? 24
Lines ? 1294
Branches ? 176
=========================================
Hits ? 1089
Misses ? 156
Partials ? 49
| Impacted Files | Coverage Δ | |
|---|---|---|
| debug_toolbar/panels/cache.py | 80.35% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update e78ac8c...e3bb007. Read the comment docs.
I'm sorry, I'm not working on this project anymore.
Could you add a test?
@lokeshatbigbasket please add a test so is more clear what do you want to fix. Thank you.
I'm closing this pull request because of inactivity, not rejecting the feature. Please resubmit if you still want to work on this, after resolving the conflicts and adding a unit test.